Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Admin UI Layout to fill viewport height #2812

Merged
merged 3 commits into from
Mar 13, 2023

Conversation

NevilleS
Copy link
Contributor

@NevilleS NevilleS commented Mar 13, 2023

Code Changes

  • Update Layout.tsx to fill the viewport with nav, header, and main divs

Steps to Confirm

  • Visually compare before / after and ensure there are no noticeable changes
Before After
fides-nightly fides-staging ethyca com_add-systems localhost_3000_

Pre-Merge Checklist

Description Of Changes

This is a small CSS change to ensure the overall app layout is consistent between the Fides and Fides Plus Admin UIs. In the Plus UI we have some pages that need to fill the viewport height, so the overall Layout needs to include height=100vh over there - by doing the same here, it just means we're less likely to get some minor discrepancies in app layouts over time without noticing.

Note: this should have no visual effect on the existing app pages! I looked at all of them (home, privacy requests, data map, management) and confirmed this... it might seem like a useless PR but I promise this makes sense 😛

@cypress
Copy link

cypress bot commented Mar 13, 2023

Passing run #768 ↗︎

0 3 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 49d1613 into ac5c29c...
Project: fides Commit: 3278acefb9 ℹ️
Status: Passed Duration: 00:54 💡
Started: Mar 13, 2023 5:36 PM Ended: Mar 13, 2023 5:37 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@NevilleS NevilleS merged commit ddaf442 into main Mar 13, 2023
@NevilleS NevilleS deleted the ns-update-layout-consistency branch March 13, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants